components/webui/imports/api/ingestion/server/CompressionDbManager.js (2)

26-31: Update JSDoc to reflect parameter changes.

The JSDoc comment still references the removed limit parameter. Please update it to describe the lastUpdateDate parameter.

- * Retrieves the last `limit` number of jobs and the ones with the given
+ * Retrieves jobs updated since the given date and the ones with the given
 * @param {string} lastUpdateDate

---

62-64: Consider optimizing the SQL query structure.

The current implementation adds the UPDATE_TIME filter to each UNION query, which could impact performance. Consider moving the filter to a WHERE clause after the UNION to improve query efficiency.

- WHERE 
-     _id=${jobId} && 
-     ${COMPRESSION_JOBS_TABLE_COLUMN_NAMES.UPDATE_TIME} >= '${lastUpdateDate}'
+ WHERE _id=${jobId}

Then add after all UNION queries:

WHERE ${COMPRESSION_JOBS_TABLE_COLUMN_NAMES.UPDATE_TIME} >= '${lastUpdateDate}'

components/webui/imports/ui/IngestView/panels/IngestionJobs/IngestionJobRow.jsx (1)

109-115: Consider using dayjs for consistent date formatting.

The component already uses dayjs for duration calculations. For consistency, consider using it for formatting update_time as well.

- text={(null === job.update_time) ?
-     "null" :
-     new Date(job.update_time).toLocaleString()}/>
+ text={(null === job.update_time) ?
+     "null" :
+     dayjs(job.update_time).format('YYYY-MM-DD HH:mm:ss')}/>

components/webui/imports/api/ingestion/server/publications.js (2)

23-23: Add a comment explaining the magic number.

The constant CONST_FOR_DATE_FORMAT = 19 is used for date string manipulation but its purpose isn't clear. Add a comment explaining that it represents the length of the MySQL datetime format "YYYY-MM-DD HH:MM:SS".

+// Length of MySQL datetime format "YYYY-MM-DD HH:MM:SS"
 const CONST_FOR_DATE_FORMAT = 19;

---

48-50: Extract date formatting logic into a helper function.

The date string manipulation logic is duplicated. Extract it into a reusable helper function to improve maintainability.

+/**
+ * Formats a date object to MySQL datetime format
+ * @param {Date} date
+ * @return {string}
+ */
+const formatToMySQLDateTime = (date) => {
+    return date.toISOString()
+        .slice(0, CONST_FOR_DATE_FORMAT)
+        .replace("T", " ");
+};
+
-let lastUpdateDate = new Date().toISOString()
-    .slice(0, CONST_FOR_DATE_FORMAT)
-    .replace("T", " ");
+let lastUpdateDate = formatToMySQLDateTime(new Date());

 // In refreshCompressionJobs:
-    const newDate = new Date().toISOString()
-        .slice(0, CONST_FOR_DATE_FORMAT)
-        .replace("T", " ");
+    const newDate = formatToMySQLDateTime(new Date());

Also applies to: 107-109

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

components/webui/imports/api/ingestion/server/publications.js (1)

106-112: ⚠️ Potential issue

Prevent potential race condition in lastUpdateDate updates.

The current implementation has a potential race condition where jobs updated between saving newDate and updating lastUpdateDate could be missed. Consider using a transaction or updating lastUpdateDate before the query.

Additionally, consider adding error handling for date operations to prevent potential runtime errors.

#!/bin/bash
# Description: Check for potential race conditions by analyzing job update patterns

# Search for concurrent job updates in the codebase
rg -A 5 "UPDATE.*COMPRESSION_JOBS.*SET" 

components/webui/imports/api/ingestion/server/publications.js (2)

23-24: Document the significance of the magic number.

The constant CONST_FOR_DATE_FORMAT = 19 appears to be the length of a MySQL datetime string (YYYY-MM-DD HH:mm:ss). Consider adding a comment explaining this or using a more descriptive constant name.

+// Length of MySQL datetime string format 'YYYY-MM-DD HH:mm:ss'
 const CONST_FOR_DATE_FORMAT = 19;

---

45-51: Extract date formatting logic into a reusable function.

The date formatting logic is duplicated between initialization and updates. Consider extracting it into a helper function to improve maintainability and reduce duplication.

+/**
+ * Formats a Date object to MySQL datetime string format
+ * @param {Date} date - The date to format
+ * @return {string} Formatted date string in 'YYYY-MM-DD HH:mm:ss' format
+ */
+const formatToMySQLDateTime = (date) => {
+    return date.toISOString()
+        .slice(0, CONST_FOR_DATE_FORMAT)
+        .replace("T", " ");
+};
+
-let lastUpdateDate = new Date().toISOString()
-    .slice(0, CONST_FOR_DATE_FORMAT)
-    .replace("T", " ");
+let lastUpdateDate = formatToMySQLDateTime(new Date());

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro